Review Request 128052: Improve agenda view in digital-clock applet

[Kai Uwe Broulik]

> On Mai 29, 2016, 10:20 nachm., Kai Uwe Broulik wrote:
> > File Attachment: Agenda view - after - Agenda view - after
> > <https://git.reviewboard.kde.org/r/128052/#fcomment589>
> >
> >     What's that?
> 
> Daniel Vrátil wrote:
>     Indicates that the event continues to the next day. IMO better than just showing "12:59 PM", but of course there might be a better indication. Maybe some icon?

Of course but for me the ellipsis looked like a glitch :) btw there's also a "usability" group which, amongst others, contains Thomas


> On Mai 29, 2016, 10:20 nachm., Kai Uwe Broulik wrote:
> > File Attachment: Agenda view - after - Agenda view - after
> > <https://git.reviewboard.kde.org/r/128052/#fcomment590>
> >
> >     I can haz multiple colors?
> 
> Daniel Vrátil wrote:
>     Depending on what? Calendar from which the events come? I assume it could be done, but how to represent ther are events from more than one calendar?

You have colors on the events already? Indeed we might need a smarter view, perhaps some lines indicating the event relative to the length of the day and/or make busier days more prominent. This is well outside the scope of this patch of course.


> On Mai 29, 2016, 10:20 nachm., Kai Uwe Broulik wrote:
> > applets/digital-clock/package/contents/ui/CalendarView.qml, line 250
> > <https://git.reviewboard.kde.org/r/128052/diff/1/?file=467275#file467275line250>
> >
> >     font.bold: true
> 
> Daniel Vrátil wrote:
>     Doesn't work for some reason :(

Plasma label sets font weight from theme which overrides that apparently, ie. font.bold true just sets weight to Font.Bold so it doesn't work because of that. Pity :)


- Kai Uwe


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128052/#review96008
-----------------------------------------------------------


On Mai 29, 2016, 10:14 nachm., Daniel Vrátil wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128052/
> -----------------------------------------------------------
> 
> (Updated Mai 29, 2016, 10:14 nachm.)
> 
> 
> Review request for Plasma, Martin Klapetek and Thomas Pfeiffer.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> -------
> 
> I've been working on CalendarEventsPlugin for the digital-clock applet to show events from Akonadi, but it turned out the agenda view in the applet is not really ready to show real-world events yet, so I played around with it for a while this evening...it's nothing fancy, but at least I feel like I can use the agenda view productively now. See screenshots below.
> 
> 
> Diffs
> -----
> 
>   applets/digital-clock/package/contents/ui/CalendarView.qml fb30c6f 
> 
> Diff: https://git.reviewboard.kde.org/r/128052/diff/
> 
> 
> Testing
> -------
> 
> 
> File Attachments
> ----------------
> 
> Agenda view - before
>   https://git.reviewboard.kde.org/media/uploaded/files/2016/05/29/583a3955-76bc-4e3b-8bc2-053c269acf22__calendar-before.png
> Agenda view - after
>   https://git.reviewboard.kde.org/media/uploaded/files/2016/05/29/316644c5-4184-4b6c-bf5f-a86cf25fa5db__calendar1.png
> Agenda view - after
>   https://git.reviewboard.kde.org/media/uploaded/files/2016/05/29/810cb0db-5844-486f-bee9-722a0299e943__calendar2.png
> Agenda view - before
>   https://git.reviewboard.kde.org/media/uploaded/files/2016/05/29/e73f7249-4ed3-4283-94d2-e92e412262b3__calendar-before.png
> Agenda view - after
>   https://git.reviewboard.kde.org/media/uploaded/files/2016/05/29/966381cf-4a0b-4adc-a68b-ddb9110a9527__calendar1.png
> Agenda view - after
>   https://git.reviewboard.kde.org/media/uploaded/files/2016/05/29/64ddc24b-be06-405e-88f6-868a4bf0f687__calendar2.png
> 
> 
> Thanks,
> 
> Daniel Vrátil
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160529/a953481f/attachment-0001.html>