[Differential] [Accepted] D1668: Add the Device to the input event summary

sebas (Sebastian Kügler) noreply at phabricator.kde.org
Thu May 26 12:45:14 UTC 2016


sebas accepted this revision.
sebas added a reviewer: sebas.
sebas added inline comments.
This revision is now accepted and ready to land.

INLINE COMMENTS

> debug_console.cpp:135
> +    if (!device) {
> +        return tableRow(i18n("Input Device"), i18nc("The input device for the event is not known", "Unknown"));
> +    }

input device *of* this event ?

> debug_console.cpp:147
>              ret.append(buttonToString(Qt::MouseButton(uint(buttons) & i)));
>              ret.append(QStringLiteral(" "));
>          }

also gets appended to the last element, so we end up with a trailing space

REPOSITORY
  rKWIN KWin

BRANCH
  debug-console-device

REVISION DETAIL
  https://phabricator.kde.org/D1668

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, Plasma, sebas
Cc: sebas, plasma-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160526/82c1a0f4/attachment.html>


More information about the Plasma-devel mailing list