<div>sebas accepted this revision.<br />
sebas added a reviewer: sebas.<br />
sebas added inline comments.<br />
This revision is now accepted and ready to land.</div><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D1668#inline-6508" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">debug_console.cpp:135</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;">    <span style="color: #aa4000">if</span> <span class="p">(</span><span style="color: #aa2211">!</span><span class="n">device</span><span class="p">)</span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;">        <span style="color: #aa4000">return</span> <span class="n">tableRow</span><span class="p">(</span><span class="n">i18n</span><span class="p">(</span><span style="color: #766510">"Input Device"</span><span class="p">),</span> <span class="n">i18nc</span><span class="p">(</span><span style="color: #766510">"The input device for the event is not known"</span><span class="p">,</span> <span style="color: #766510">"Unknown"</span><span class="p">));</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;">    <span class="p">}</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">input device *of* this event ?</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D1668#inline-6509" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">debug_console.cpp:147</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; ">            <span class="n">ret</span><span class="p">.</span><span class="n">append</span><span class="p">(</span><span class="n">buttonToString</span><span class="p">(</span><span class="n">Qt</span><span style="color: #aa2211">::</span><span class="n">MouseButton</span><span class="p">(</span><span class="n">uint</span><span class="p">(</span><span class="n">buttons</span><span class="p">)</span> <span style="color: #aa2211">&</span> <span class="n">i</span><span class="p">)));</span>
</div><div style="padding: 0 8px; margin: 0 4px; ">            <span class="n">ret</span><span class="p">.</span><span class="n">append</span><span class="p">(</span><span class="n">QStringLiteral</span><span class="p">(</span><span style="color: #766510">" "</span><span class="p">));</span>
</div><div style="padding: 0 8px; margin: 0 4px; ">        <span class="p">}</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">also gets appended to the last element, so we end up with a trailing space</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>rKWIN KWin</div></div></div><br /><div><strong>BRANCH</strong><div><div>debug-console-device</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D1668" rel="noreferrer">https://phabricator.kde.org/D1668</a></div></div><br /><div><strong>EMAIL PREFERENCES</strong><div><a href="https://phabricator.kde.org/settings/panel/emailpreferences/" rel="noreferrer">https://phabricator.kde.org/settings/panel/emailpreferences/</a></div></div><br /><div><strong>To: </strong>graesslin, Plasma, sebas<br /><strong>Cc: </strong>sebas, plasma-devel<br /></div>