[Differential] [Commented On] D1651: Fix saving of calendar events plugins and holidays regions

drosca (David Rosca) noreply at phabricator.kde.org
Mon May 23 13:11:43 UTC 2016


drosca added inline comments.

INLINE COMMENTS

> mart wrote in HolidaysConfig.qml:84
> shouldn't be onCheckedChanged, as this can happen by keyboard as well?

It can't be checked by keyboard, because there is nothing connected to the `toggleCurrent` signal that is emitted when pressing space.
Also if I change it to `onCheckedChanged` then there is a binding loop.

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D1651

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: drosca, Plasma, mck182, mart
Cc: mart, plasma-devel, sebas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160523/19138719/attachment-0001.html>


More information about the Plasma-devel mailing list