[Differential] [Requested Changes To] D1651: Fix saving of calendar events plugins and holidays regions

mart (Marco Martin) noreply at phabricator.kde.org
Mon May 23 08:34:20 UTC 2016


mart requested changes to this revision.
mart added a reviewer: mart.
mart added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> HolidaysConfig.qml:84
>                      activeFocusOnTab: false // only let the TableView as a whole get focus
>                      onClicked: {
>                          //needed for model's setData to be called

shouldn't be onCheckedChanged, as this can happen by keyboard as well?

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D1651

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: drosca, Plasma, mck182, mart
Cc: mart, plasma-devel, sebas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160523/b70e05f6/attachment.html>


More information about the Plasma-devel mailing list