Review Request 127889: [QuickTheme] Fix properties

Kai Uwe Broulik kde at privat.broulik.de
Tue May 10 17:16:58 UTC 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127889/
-----------------------------------------------------------

(Updated May 10, 2016, 5:16 p.m.)


Status
------

This change has been marked as submitted.


Review request for Plasma and David Faure.


Changes
-------

Submitted with commit f78685389a870c4c89e93e1dc71826f97e13a075 by Kai Uwe Broulik to branch master.


Repository: plasma-framework


Description
-------

Some properties were duplicated (yay moc for not shouting at us), some were accessing the wrong getter and some were missing.


Diffs
-----

  src/declarativeimports/core/quicktheme.h 936cc0c 

Diff: https://git.reviewboard.kde.org/r/127889/diff/


Testing
-------

I now get proper white highlight text color in text fields again which use viewHighlightedTextColor

Tagging for upcomign frameworks release already happened, release is due Saturday, so we need a re-spin since the broken highlight in text fields is an awful regression.


Thanks,

Kai Uwe Broulik

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160510/3c0458e5/attachment.html>


More information about the Plasma-devel mailing list