Review Request 127889: [QuickTheme] Fix properties

[Marco Martin]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127889/#review95364
-----------------------------------------------------------


Ship it!




Ship It!

- Marco Martin


On May 10, 2016, 3:50 p.m., Kai Uwe Broulik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127889/
> -----------------------------------------------------------
> 
> (Updated May 10, 2016, 3:50 p.m.)
> 
> 
> Review request for Plasma and David Faure.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> -------
> 
> Some properties were duplicated (yay moc for not shouting at us), some were accessing the wrong getter and some were missing.
> 
> 
> Diffs
> -----
> 
>   src/declarativeimports/core/quicktheme.h 936cc0c 
> 
> Diff: https://git.reviewboard.kde.org/r/127889/diff/
> 
> 
> Testing
> -------
> 
> I now get proper white highlight text color in text fields again which use viewHighlightedTextColor
> 
> Tagging for upcomign frameworks release already happened, release is due Saturday, so we need a re-spin since the broken highlight in text fields is an awful regression.
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160510/33c7214b/attachment.html>