[Differential] [Request, 15 lines] D1578: [Notifications] Unbreak notification actions
broulik (Kai Uwe Broulik)
noreply at phabricator.kde.org
Mon May 9 17:23:13 UTC 2016
broulik created this revision.
broulik added a reviewer: Plasma.
broulik set the repository for this revision to rPLASMAWORKSPACE Plasma Workspace.
broulik added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
The change back to a MouseEventListener broke notification actions because its onClicked handler would fire before the action buttons closing the notification before it had a chance to trigger the action.
TEST PLAN
I'm not sure we can rely on the order of events but I suppose MEL filters from parent to child?
In any way we should avoid the close call after triggering an action.
REPOSITORY
rPLASMAWORKSPACE Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D1578
AFFECTED FILES
applets/notifications/package/contents/ui/NotificationItem.qml
applets/notifications/package/contents/ui/NotificationPopup.qml
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: broulik, Plasma
Cc: plasma-devel, sebas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160509/965334b4/attachment.html>
More information about the Plasma-devel
mailing list