Review Request 127755: [IconItem] Clearing pixmap makes toolbuttons invisible in some conditions

[Anthony Fieroni]

> On Април 29, 2016, 12:49 след обяд, Marco Martin wrote:
> > you removed the way it had to disable animations when it passed from visible to invisible.
> > this will probably bring back the weird animation of icons when the tooltips come up
> 
> Anthony Fieroni wrote:
>     I can't notice any icon animation whe tooltip cames up. Maybe this was be in the past?
> 
> Anthony Fieroni wrote:
>     DefaultToolTip.qml:57 'animated: false' prevent from icon animation
> 
> Kai Uwe Broulik wrote:
>     It was disabled in the tooltip because we have the morphing effect now which also fades. Check out the OSD, though.

For me, the patch is quite ugly it's not done right


- Anthony


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127755/#review95006
-----------------------------------------------------------


On Април 28, 2016, 9:59 преди обяд, Anthony Fieroni wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127755/
> -----------------------------------------------------------
> 
> (Updated Април 28, 2016, 9:59 преди обяд)
> 
> 
> Review request for Plasma, Kai Uwe Broulik, David Rosca, and Marco Martin.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> -------
> 
> So toolbutton works, what is broken now? :)
> 
> 
> Diffs
> -----
> 
>   autotests/iconitemtest.cpp db63e49 
>   src/declarativeimports/core/iconitem.h 38a9c7a 
>   src/declarativeimports/core/iconitem.cpp 12008f8 
> 
> Diff: https://git.reviewboard.kde.org/r/127755/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Anthony Fieroni
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160503/28e341da/attachment.html>