Review Request 127755: [IconItem] Clearing pixmap makes toolbuttons invisible in some conditions

[Anthony Fieroni]

> On Април 27, 2016, 1:15 след обяд, David Edmundson wrote:
> > In what conditions is it broken and why does it break?
> 
> Anthony Fieroni wrote:
>     https://git.reviewboard.kde.org/r/127753/
>     It has screenshots.
> 
> David Edmundson wrote:
>     I can see a picture where it is broken. I believe that at some point it gets broken.
>     
>     I want to know why:
>     
>     I.e 
>     "if X happens before Y when Z is set, this causes someFunction to set m_someVariable to be null, resulting in SomeClass::someMethod not rendering the icon"
> 
> Anthony Fieroni wrote:
>     I *really* don't know *why*. It happens when button is hovered and makes a move to task item. Button disapears rather than to be drawed without hover.

I think, it's not prove it, pixmap is cleared right before draw is called, so button is drawed with empty pixmap => invisible.


- Anthony


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127755/#review94898
-----------------------------------------------------------


On Април 28, 2016, 9:59 преди обяд, Anthony Fieroni wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127755/
> -----------------------------------------------------------
> 
> (Updated Април 28, 2016, 9:59 преди обяд)
> 
> 
> Review request for Plasma, Kai Uwe Broulik, David Rosca, and Marco Martin.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> -------
> 
> So toolbutton works, what is broken now? :)
> 
> 
> Diffs
> -----
> 
>   autotests/iconitemtest.cpp db63e49 
>   src/declarativeimports/core/iconitem.h 38a9c7a 
>   src/declarativeimports/core/iconitem.cpp 12008f8 
> 
> Diff: https://git.reviewboard.kde.org/r/127755/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Anthony Fieroni
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160502/638082f4/attachment.html>