Review Request 127802: [Converter Runner] Try QLocale::toDouble to get input value

Kai Uwe Broulik kde at privat.broulik.de
Mon May 2 19:12:37 UTC 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127802/
-----------------------------------------------------------

(Updated May 2, 2016, 7:12 p.m.)


Status
------

This change has been marked as submitted.


Review request for Plasma.


Changes
-------

Submitted with commit 54a37fc80c33c1f76faa4975868d1cc824d38dc2 by Kai Uwe Broulik to branch Plasma/5.6.


Repository: kdeplasma-addons


Description
-------

Only if that fails, it tries QString::toDouble and if even that fails it skips. This allows the user to enter numbers in a more natural way.


Diffs
-----

  runners/converter/converterrunner.cpp d9cffc3 

Diff: https://git.reviewboard.kde.org/r/127802/diff/


Testing
-------

I can now convert "5,5ft" (comma being the decimal indicator in German) or "1.524m" (period being the thousand separator in German).

I can also still enter "5.5ft".


Thanks,

Kai Uwe Broulik

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160502/8beb6f1b/attachment.html>


More information about the Plasma-devel mailing list