Review Request 127802: [Converter Runner] Try QLocale::toDouble to get input value

[David Edmundson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127802/#review95104
-----------------------------------------------------------


Ship it!




Ship It!

- David Edmundson


On April 30, 2016, 11 p.m., Kai Uwe Broulik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127802/
> -----------------------------------------------------------
> 
> (Updated April 30, 2016, 11 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: kdeplasma-addons
> 
> 
> Description
> -------
> 
> Only if that fails, it tries QString::toDouble and if even that fails it skips. This allows the user to enter numbers in a more natural way.
> 
> 
> Diffs
> -----
> 
>   runners/converter/converterrunner.cpp d9cffc3 
> 
> Diff: https://git.reviewboard.kde.org/r/127802/diff/
> 
> 
> Testing
> -------
> 
> I can now convert "5,5ft" (comma being the decimal indicator in German) or "1.524m" (period being the thousand separator in German).
> 
> I can also still enter "5.5ft".
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160502/0484ce4f/attachment-0001.html>