Review Request 127755: [IconItem] Clearing pixmap makes toolbuttons invisible in some conditions

[David Edmundson]

> On April 27, 2016, 10:15 a.m., David Edmundson wrote:
> > In what conditions is it broken and why does it break?
> 
> Anthony Fieroni wrote:
>     https://git.reviewboard.kde.org/r/127753/
>     It has screenshots.

I can see a picture where it is broken. I believe that at some point it gets broken.

I want to know why:

I.e 
"if X happens before Y when Z is set, this causes someFunction to set m_someVariable to be null, resulting in SomeClass::someMethod not rendering the icon"


- David


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127755/#review94898
-----------------------------------------------------------


On April 28, 2016, 6:59 a.m., Anthony Fieroni wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127755/
> -----------------------------------------------------------
> 
> (Updated April 28, 2016, 6:59 a.m.)
> 
> 
> Review request for Plasma, Kai Uwe Broulik, David Rosca, and Marco Martin.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> -------
> 
> So toolbutton works, what is broken now? :)
> 
> 
> Diffs
> -----
> 
>   autotests/iconitemtest.cpp db63e49 
>   src/declarativeimports/core/iconitem.h 38a9c7a 
>   src/declarativeimports/core/iconitem.cpp 12008f8 
> 
> Diff: https://git.reviewboard.kde.org/r/127755/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Anthony Fieroni
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160502/f7278c38/attachment.html>