Review Request 127755: [IconItem] Clearing pixmap makes toolbuttons invisible in some conditions

[Kai Uwe Broulik]

> On April 29, 2016, 9:49 vorm., Marco Martin wrote:
> > you removed the way it had to disable animations when it passed from visible to invisible.
> > this will probably bring back the weird animation of icons when the tooltips come up
> 
> Anthony Fieroni wrote:
>     I can't notice any icon animation whe tooltip cames up. Maybe this was be in the past?
> 
> Anthony Fieroni wrote:
>     DefaultToolTip.qml:57 'animated: false' prevent from icon animation

It was disabled in the tooltip because we have the morphing effect now which also fades. Check out the OSD, though.


- Kai Uwe


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127755/#review95006
-----------------------------------------------------------


On April 28, 2016, 6:59 vorm., Anthony Fieroni wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127755/
> -----------------------------------------------------------
> 
> (Updated April 28, 2016, 6:59 vorm.)
> 
> 
> Review request for Plasma, Kai Uwe Broulik, David Rosca, and Marco Martin.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> -------
> 
> So toolbutton works, what is broken now? :)
> 
> 
> Diffs
> -----
> 
>   autotests/iconitemtest.cpp db63e49 
>   src/declarativeimports/core/iconitem.h 38a9c7a 
>   src/declarativeimports/core/iconitem.cpp 12008f8 
> 
> Diff: https://git.reviewboard.kde.org/r/127755/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Anthony Fieroni
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160502/c69c750e/attachment.html>