Review Request 127812: Fix the return value of Plasma::Service::operationDescription() for the docs

[R.Harish Navnit]

> On May 2, 2016, 6:32 p.m., Marco Martin wrote:
> > Ship It!

Thanks. Can you also tell me how the example(i.e L69 - L64) would look now ? I'm having to do something similar while porting some code in the publictransport repo.


- R.Harish


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127812/#review95074
-----------------------------------------------------------


On May 2, 2016, 6:30 p.m., R.Harish  Navnit wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127812/
> -----------------------------------------------------------
> 
> (Updated May 2, 2016, 6:30 p.m.)
> 
> 
> Review request for Plasma, Bhushan Shah and Eike Hein.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> -------
> 
> In KDE4, Plasma::Service::operationDescription() returned a KConfigGroup, but in frameworks, the same function returns a QVariantMap. This doesn't seem to be updated in the comments hence rendering the documentation slightly misleading. 
> 
> The sample use example should also be modified accordingly, but I'm not sure how it's done. I'd be happy to update the RR with that as well, if someone can guide me through.
> 
> 
> Diffs
> -----
> 
>   src/plasma/service.h 19cc965d23ed2a1e51ce6c52cb1de9f6bce3069c 
> 
> Diff: https://git.reviewboard.kde.org/r/127812/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> R.Harish  Navnit
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160502/5f9b65e1/attachment.html>