Review Request 127812: Fix the return value of Plasma::Service::operationDescription() for the docs

[Marco Martin]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127812/#review95074
-----------------------------------------------------------


Ship it!




Ship It!

- Marco Martin


On May 2, 2016, 1 p.m., R.Harish  Navnit wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127812/
> -----------------------------------------------------------
> 
> (Updated May 2, 2016, 1 p.m.)
> 
> 
> Review request for Plasma, Bhushan Shah and Eike Hein.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> -------
> 
> In KDE4, Plasma::Service::operationDescription() returned a KConfigGroup, but in frameworks, the same function returns a QVariantMap. This doesn't seem to be updated in the comments hence rendering the documentation slightly misleading. 
> 
> The sample use example should also be modified accordingly, but I'm not sure how it's done. I'd be happy to update the RR with that as well, if someone can guide me through.
> 
> 
> Diffs
> -----
> 
>   src/plasma/service.h 19cc965d23ed2a1e51ce6c52cb1de9f6bce3069c 
> 
> Diff: https://git.reviewboard.kde.org/r/127812/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> R.Harish  Navnit
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160502/dcb4b146/attachment.html>