Review Request 127260: Experiment: cache svg icons from icon theme

[Marco Martin]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127260/
-----------------------------------------------------------

(Updated March 31, 2016, 1:07 p.m.)


Review request for Plasma.


Changes
-------

added a test that ensures that when the icon theme changes, repaintneeded from the svg is emitted.
I'm unsure wether to pursue this direction, or rather modifying setImagePath as follows:

rather than like now going
when svg->setImagePath("icon/foo") is called (with icon/ prefix)

tries first in the current plasma theme, then in the current icon theme, then in the default plasma theme
if no actual svg file will be found, svg will be not valid

IconItem component would be modified accordingly


Repository: plasma-framework


Description
-------

this attempts to cache as well svg icons from the icon theme (invalidating as well when the icon theme is updated)

still to be done, to figure out to invalidate cache when the icon theme is changed in the two cases:
* theme changed with plasmashell running
* theme changed with plasma shell not running


Diffs (updated)
-----

  autotests/CMakeLists.txt d475ac3 
  autotests/data/icons/test-theme-two/apps/22/tst-plasma-framework-test-icon.svg PRE-CREATION 
  autotests/data/icons/test-theme-two/index.theme PRE-CREATION 
  autotests/themetest.h PRE-CREATION 
  autotests/themetest.cpp PRE-CREATION 
  src/plasma/private/theme_p.h 69a8934 
  src/plasma/private/theme_p.cpp 98bccab 
  src/plasma/svg.cpp 6c9c75c 

Diff: https://git.reviewboard.kde.org/r/127260/diff/


Testing
-------


Thanks,

Marco Martin

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160331/a63081e9/attachment.html>