Review Request 127260: Experiment: cache svg icons from icon theme

[Marco Martin]

> On March 4, 2016, 8:52 p.m., David Edmundson wrote:
> > src/plasma/private/theme_p.cpp, line 233
> > <https://git.reviewboard.kde.org/r/127260/diff/2/?file=447948#file447948line233>
> >
> >     I'm not sure this works.
> >     This compares if the cache file > icon file.
> >     
> >     This is a shared cache; both in terms of a file and mmapd memory.
> >     so what happens when you run krunner and plasmashell at the same time when you upgrade and you change icons -  one will update, the other won't.
> 
> Marco Martin wrote:
>     hmm, i'm monitoring also kicontheme signals as well for runtime changes, both processes should get it, no?
> 
> David Edmundson wrote:
>     if you're relying on the themeChanged signal being enough, then what is this code for?

in the case the change happened when the application (plasmashell or krunner) is not running


- Marco


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127260/#review93174
-----------------------------------------------------------


On March 4, 2016, 11:04 a.m., Marco Martin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127260/
> -----------------------------------------------------------
> 
> (Updated March 4, 2016, 11:04 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> -------
> 
> this attempts to cache as well svg icons from the icon theme (invalidating as well when the icon theme is updated)
> 
> still to be done, to figure out to invalidate cache when the icon theme is changed in the two cases:
> * theme changed with plasmashell running
> * theme changed with plasma shell not running
> 
> 
> Diffs
> -----
> 
>   src/plasma/private/theme_p.h 69a8934 
>   src/plasma/private/theme_p.cpp 943d3af 
>   src/plasma/svg.cpp ccd248a 
> 
> Diff: https://git.reviewboard.kde.org/r/127260/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Marco Martin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160309/701a7c77/attachment.html>