Review Request 127484: applet: Add streams tab to manage applications volume

[David Rosca]

> On March 25, 2016, 5:31 p.m., Andreas Kainz wrote:
> > I'm not a big fan when you have one hidden feature to show an expand arrow.
> > 
> > what's the difference between applications and devices? the grouping? in general I'm a big fan of a simple volumen widget where you can change the volumen and an advanced kcm where you can than switch between audio cards, different output's, ...
> > 
> > why in general do we have different sections. I like the windows way change volumen for the device (for all apps) or change volumen for a single app. without tabs, groups, ...

The arrow is no more, I've removed the combobox to change device.

Why aren't the streams and devices in one list? I guess the reason against it (as it was already in the code, just commented) was because it made the ui too cluttered. As for my usecase, I don't really care about volume of devices (I use global shortcuts for that), but instead I'd like to just change the volume of one application and having it in separate tab makes it easier for me to quickly find the application.


- David


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127484/#review93994
-----------------------------------------------------------


On March 25, 2016, 2:38 p.m., David Rosca wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127484/
> -----------------------------------------------------------
> 
> (Updated March 25, 2016, 2:38 p.m.)
> 
> 
> Review request for Plasma and KDE Usability.
> 
> 
> Repository: plasma-pa
> 
> 
> Description
> -------
> 
> Applet now have two tabs: Devices and Streams.
> If there are more audo devices, streams can be moved between them with combobox that is visible after clicking on stream item.
> 
> BUG: 352042
> BUG: 353232
> 
> 
> Diffs
> -----
> 
>   applet/contents/ui/ListItemBase.qml 2e31eeb 
>   applet/contents/ui/SinkInputListItem.qml 3867007 
>   applet/contents/ui/SourceOutputListItem.qml 3b684fc 
>   applet/contents/ui/StreamListItem.qml PRE-CREATION 
>   applet/contents/ui/StreamListItemBase.qml 7c0af12 
>   applet/contents/ui/main.qml bf6f683 
>   src/pulseaudio.h 9fc9656 
>   src/pulseaudio.cpp 1488784 
> 
> Diff: https://git.reviewboard.kde.org/r/127484/diff/
> 
> 
> Testing
> -------
> 
> Everything seems to work fine.
> 
> 
> File Attachments
> ----------------
> 
> applet-devices.png
>   https://git.reviewboard.kde.org/media/uploaded/files/2016/03/24/d1f444cd-c69b-4888-a0c0-24bc4b6b8904__applet-devices.png
> applet-streams.png
>   https://git.reviewboard.kde.org/media/uploaded/files/2016/03/24/30a3cdfb-b6b5-41c7-bb15-37c6b87604a4__applet-streams.png
> applet-streams-more-devices.png
>   https://git.reviewboard.kde.org/media/uploaded/files/2016/03/24/82f0eb13-95a5-4d0c-b50b-682cf7c3b384__applet-streams-more-devices.png
> applet-streams-more-devices.png
>   https://git.reviewboard.kde.org/media/uploaded/files/2016/03/24/b2dafc91-4bde-42dc-bfd5-036ee001b984__applet-streams-more-devices.png
> 
> 
> Thanks,
> 
> David Rosca
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160325/04a99aba/attachment.html>