<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/127484/">https://git.reviewboard.kde.org/r/127484/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On March 25th, 2016, 5:31 p.m. UTC, <b>Andreas Kainz</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I'm not a big fan when you have one hidden feature to show an expand arrow.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">what's the difference between applications and devices? the grouping? in general I'm a big fan of a simple volumen widget where you can change the volumen and an advanced kcm where you can than switch between audio cards, different output's, ...</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">why in general do we have different sections. I like the windows way change volumen for the device (for all apps) or change volumen for a single app. without tabs, groups, ...</p></pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">The arrow is no more, I've removed the combobox to change device.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Why aren't the streams and devices in one list? I guess the reason against it (as it was already in the code, just commented) was because it made the ui too cluttered. As for my usecase, I don't really care about volume of devices (I use global shortcuts for that), but instead I'd like to just change the volume of one application and having it in separate tab makes it easier for me to quickly find the application.</p></pre>
<br />
<p>- David</p>
<br />
<p>On March 25th, 2016, 2:38 p.m. UTC, David Rosca wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Plasma and KDE Usability.</div>
<div>By David Rosca.</div>
<p style="color: grey;"><i>Updated March 25, 2016, 2:38 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-pa
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Applet now have two tabs: Devices and Streams.
If there are more audo devices, streams can be moved between them with combobox that is visible after clicking on stream item.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">BUG: 352042
BUG: 353232</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Everything seems to work fine.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>applet/contents/ui/ListItemBase.qml <span style="color: grey">(2e31eeb)</span></li>
<li>applet/contents/ui/SinkInputListItem.qml <span style="color: grey">(3867007)</span></li>
<li>applet/contents/ui/SourceOutputListItem.qml <span style="color: grey">(3b684fc)</span></li>
<li>applet/contents/ui/StreamListItem.qml <span style="color: grey">(PRE-CREATION)</span></li>
<li>applet/contents/ui/StreamListItemBase.qml <span style="color: grey">(7c0af12)</span></li>
<li>applet/contents/ui/main.qml <span style="color: grey">(bf6f683)</span></li>
<li>src/pulseaudio.h <span style="color: grey">(9fc9656)</span></li>
<li>src/pulseaudio.cpp <span style="color: grey">(1488784)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/127484/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments </h1>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2016/03/24/d1f444cd-c69b-4888-a0c0-24bc4b6b8904__applet-devices.png">applet-devices.png</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2016/03/24/30a3cdfb-b6b5-41c7-bb15-37c6b87604a4__applet-streams.png">applet-streams.png</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2016/03/24/82f0eb13-95a5-4d0c-b50b-682cf7c3b384__applet-streams-more-devices.png">applet-streams-more-devices.png</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2016/03/24/b2dafc91-4bde-42dc-bfd5-036ee001b984__applet-streams-more-devices.png">applet-streams-more-devices.png</a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>