Review Request 127409: Make sure we're not forcing the window to be created prematurely
Kai Uwe Broulik
kde at privat.broulik.de
Thu Mar 24 15:23:15 UTC 2016
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127409/#review93934
-----------------------------------------------------------
src/plasmaquick/dialog.cpp (lines 1000 - 1001)
<https://git.reviewboard.kde.org/r/127409/#comment63989>
Braces pls
- Kai Uwe Broulik
On März 17, 2016, 2:13 vorm., Aleix Pol Gonzalez wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127409/
> -----------------------------------------------------------
>
> (Updated März 17, 2016, 2:13 vorm.)
>
>
> Review request for KDE Frameworks and Plasma.
>
>
> Repository: plasma-framework
>
>
> Description
> -------
>
> Only update the properties that require a winId when visible, otherwise let updateVisibility() take care about them.
>
>
> Diffs
> -----
>
> src/plasmaquick/dialog.cpp 7bb63c5
>
> Diff: https://git.reviewboard.kde.org/r/127409/diff/
>
>
> Testing
> -------
>
> I don't get platform creations being forced on gdb.
>
>
> Thanks,
>
> Aleix Pol Gonzalez
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160324/f8c75c1f/attachment-0001.html>
More information about the Plasma-devel
mailing list