Review Request 127476: [Volume item] Increase / decrease by wheel

[Anthony Fieroni]

> On Март 24, 2016, 8:25 преди обяд, David Rosca wrote:
> > Please see https://git.reviewboard.kde.org/r/125088/. I myself am against blocking it, but there is a valid reason for it.
> > 
> > Also, I think you can just remove the MouseArea (as Slider allows to change value with mouse wheel by default) instead of reimplementing the logic.

I'm not removing MouseArea to not fooling the updateTimer, if it can happen. Actual volume is changed in applet and kcm, current code of src/kcm/package/contents/ui/VolumeSlider.qml is without MouseArea, i can remove it.
Same code on 2 side => horrible nightmare


- Anthony


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127476/#review93911
-----------------------------------------------------------


On Март 23, 2016, 7:43 след обяд, Anthony Fieroni wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127476/
> -----------------------------------------------------------
> 
> (Updated Март 23, 2016, 7:43 след обяд)
> 
> 
> Review request for Plasma and Harald Sitter.
> 
> 
> Repository: plasma-pa
> 
> 
> Description
> -------
> 
> I don't know why it's disabled, it's pretty handy
> 
> 
> Diffs
> -----
> 
>   applet/contents/ui/ListItemBase.qml 2e31eeb 
> 
> Diff: https://git.reviewboard.kde.org/r/127476/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Anthony Fieroni
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160324/9a6d228b/attachment.html>