Review Request 127476: [Volume item] Increase / decrease by wheel

[David Rosca]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127476/#review93911
-----------------------------------------------------------



Please see https://git.reviewboard.kde.org/r/125088/. I myself am against blocking it, but there is a valid reason for it.

Also, I think you can just remove the MouseArea (as Slider allows to change value with mouse wheel by default) instead of reimplementing the logic.

- David Rosca


On March 23, 2016, 5:43 p.m., Anthony Fieroni wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127476/
> -----------------------------------------------------------
> 
> (Updated March 23, 2016, 5:43 p.m.)
> 
> 
> Review request for Plasma and Harald Sitter.
> 
> 
> Repository: plasma-pa
> 
> 
> Description
> -------
> 
> I don't know why it's disabled, it's pretty handy
> 
> 
> Diffs
> -----
> 
>   applet/contents/ui/ListItemBase.qml 2e31eeb 
> 
> Diff: https://git.reviewboard.kde.org/r/127476/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Anthony Fieroni
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160324/083c4ace/attachment.html>