Review Request 127365: [plasma-sdk] Make Qt5Test really optional, fix plasmate dependencies

Andreas Sturmlechner andreas.sturmlechner at gmail.com
Wed Mar 23 12:03:43 UTC 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127365/
-----------------------------------------------------------

(Updated March 23, 2016, 5:03 a.m.)


Status
------

This change has been marked as submitted.


Review request for Plasma.


Changes
-------

Submitted with commit a3176e4ef2f09c766e22bceb0855beff8fe2f344 by Andreas Sturmlechner to branch master.


Repository: plasma-sdk


Description
-------

KF5NewStuff, KF5Parts are only required for plasmate. Could not push KF5ItemModels down into plasmate without breaking build. Is it a problem with KDevPlatform linking?

Also, fixes reviewboardrc.


Diffs
-----

  .reviewboardrc d6b7a1b1d87b33fadcbfc6316dcacf543b969eb0 
  CMakeLists.txt b556de6333b9dde3a4470dad692b3b3b9cf2f7e7 
  cuttlefish/CMakeLists.txt 6eaa78aa60caa83446456bdfb5126b8e9fdce11c 
  plasmate/CMakeLists.txt 8f28ec400cb80a8af92ea4fcb86be195e3aebd13 

Diff: https://git.reviewboard.kde.org/r/127365/diff/


Testing
-------

Built fine with and without plasmate.


Thanks,

Andreas Sturmlechner

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160323/5694e292/attachment.html>


More information about the Plasma-devel mailing list