Review Request 127365: [plasma-sdk] Make Qt5Test really optional, fix plasmate dependencies

[Marco Martin]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127365/#review93887
-----------------------------------------------------------


Ship it!




Ship It!

- Marco Martin


On March 13, 2016, 4:43 p.m., Andreas Sturmlechner wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127365/
> -----------------------------------------------------------
> 
> (Updated March 13, 2016, 4:43 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-sdk
> 
> 
> Description
> -------
> 
> KF5NewStuff, KF5Parts are only required for plasmate. Could not push KF5ItemModels down into plasmate without breaking build. Is it a problem with KDevPlatform linking?
> 
> Also, fixes reviewboardrc.
> 
> 
> Diffs
> -----
> 
>   .reviewboardrc d6b7a1b1d87b33fadcbfc6316dcacf543b969eb0 
>   CMakeLists.txt b556de6333b9dde3a4470dad692b3b3b9cf2f7e7 
>   cuttlefish/CMakeLists.txt 6eaa78aa60caa83446456bdfb5126b8e9fdce11c 
>   plasmate/CMakeLists.txt 8f28ec400cb80a8af92ea4fcb86be195e3aebd13 
> 
> Diff: https://git.reviewboard.kde.org/r/127365/diff/
> 
> 
> Testing
> -------
> 
> Built fine with and without plasmate.
> 
> 
> Thanks,
> 
> Andreas Sturmlechner
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160323/71e208a5/attachment.html>