Review Request 126210: [phonon] Do not set RPATH

[Harald Sitter]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126210/#review93646
-----------------------------------------------------------



I can't really give a ship it seeing as I do not comprehend what this was meant to achieve to begin with and the code bit predates even kde-runtime's git history...

Please add the buildsystem group to the reviewers list. If no one complains in a week consider this your shipit.

(FTR: I am pretty sure ECM deals with rpaths already, so whatever this code bit does is probably superfluous nonesense anyway)

- Harald Sitter


On Jan. 22, 2016, 8:35 p.m., Andreas Sturmlechner wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126210/
> -----------------------------------------------------------
> 
> (Updated Jan. 22, 2016, 8:35 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> -------
> 
> This very old piece of code triggers a scanelf warning during build. I don't know why it is there, hopefully someone knows.
> 
> 
> Diffs
> -----
> 
>   phonon/platform_kde/CMakeLists.txt 281425fb6f6c1a41f14399ac17f8a94cd99507ad 
> 
> Diff: https://git.reviewboard.kde.org/r/126210/diff/
> 
> 
> Testing
> -------
> 
> Builds, and runs (unfortunately can't run the tests), phonon test playback included.
> 
> 
> Thanks,
> 
> Andreas Sturmlechner
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160317/8dc42698/attachment.html>