Review Request 127382: Avoid blocking DBus call to kded

[Jan Grulich]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127382/#review93555
-----------------------------------------------------------




libs/handler.h (line 33)
<https://git.reviewboard.kde.org/r/127382/#comment63779>

    Why this include? It doesn't compile with it, I removed it and it compiles just fine.


- Jan Grulich


On Bře. 15, 2016, 2:16 odp., David Edmundson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127382/
> -----------------------------------------------------------
> 
> (Updated Bře. 15, 2016, 2:16 odp.)
> 
> 
> Review request for Plasma and Jan Grulich.
> 
> 
> Repository: plasma-nm
> 
> 
> Description
> -------
> 
> There are two blocking calls here; the QDBusInterface constructor which does introspection and
> the init method.
> 
> It should be fine to do blocking calls to kded, but given we don't need
> to, we may as well avoid them.
> 
> 
> Diffs
> -----
> 
>   libs/handler.h 28056c676b71c56582f4430f8b609675f050b0f7 
>   libs/handler.cpp 20db5201a2723300d923ecb5be652e6346230517 
> 
> Diff: https://git.reviewboard.kde.org/r/127382/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160315/46cc41f2/attachment.html>