Review Request 127382: Avoid blocking DBus call to kded

David Edmundson david at davidedmundson.co.uk
Tue Mar 15 14:16:33 UTC 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127382/
-----------------------------------------------------------

Review request for Plasma and Jan Grulich.


Repository: plasma-nm


Description
-------

There are two blocking calls here; the QDBusInterface constructor which does introspection and
the init method.

It should be fine to do blocking calls to kded, but given we don't need
to, we may as well avoid them.


Diffs
-----

  libs/handler.h 28056c676b71c56582f4430f8b609675f050b0f7 
  libs/handler.cpp 20db5201a2723300d923ecb5be652e6346230517 

Diff: https://git.reviewboard.kde.org/r/127382/diff/


Testing
-------


Thanks,

David Edmundson

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160315/ab827690/attachment-0001.html>


More information about the Plasma-devel mailing list