Review Request 127355: Replace QMenu::exec with QMenu::popup
David Rosca
nowrep at gmail.com
Sat Mar 12 12:11:52 UTC 2016
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127355/
-----------------------------------------------------------
(Updated March 12, 2016, 12:11 p.m.)
Status
------
This change has been marked as submitted.
Review request for Plasma.
Changes
-------
Submitted with commit 8f6d1f17e455334fe64b879bcb90bdc238b22696 by David Rosca to branch master.
Repository: plasma-framework
Description
-------
^^
Diffs
-----
src/scriptengines/qml/plasmoid/appletinterface.cpp 2337652
src/scriptengines/qml/plasmoid/containmentinterface.h fe6e6db
src/scriptengines/qml/plasmoid/containmentinterface.cpp f44bd07
Diff: https://git.reviewboard.kde.org/r/127355/diff/
Testing
-------
Works as before. There are still two places where QMenu::exec is used (containmentinterface.cpp: processMimeData and mimeTypeRetrieved) but the code is much more complex to replace.
Thanks,
David Rosca
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160312/7c569887/attachment.html>
More information about the Plasma-devel
mailing list