Review Request 127355: Replace QMenu::exec with QMenu::popup

[Marco Martin]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127355/#review93446
-----------------------------------------------------------


Ship it!




- Marco Martin


On March 12, 2016, 11:58 a.m., David Rosca wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127355/
> -----------------------------------------------------------
> 
> (Updated March 12, 2016, 11:58 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> -------
> 
> ^^
> 
> 
> Diffs
> -----
> 
>   src/scriptengines/qml/plasmoid/appletinterface.cpp 2337652 
>   src/scriptengines/qml/plasmoid/containmentinterface.h fe6e6db 
>   src/scriptengines/qml/plasmoid/containmentinterface.cpp f44bd07 
> 
> Diff: https://git.reviewboard.kde.org/r/127355/diff/
> 
> 
> Testing
> -------
> 
> Works as before. There are still two places where QMenu::exec is used (containmentinterface.cpp: processMimeData and mimeTypeRetrieved) but the code is much more complex to replace.
> 
> 
> Thanks,
> 
> David Rosca
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160312/186f2a7d/attachment.html>