Review Request 127344: FrameSvg: Fix dangling pointers in sharedFrames when theme changes

David Rosca nowrep at gmail.com
Sat Mar 12 12:11:50 UTC 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127344/
-----------------------------------------------------------

(Updated March 12, 2016, 12:11 p.m.)


Status
------

This change has been marked as submitted.


Review request for Plasma.


Changes
-------

Submitted with commit 974a2b5071b4f0c12a97525d18c8cf7c5c93f548 by David Rosca to branch master.


Repository: plasma-framework


Description
-------

Store theme pointer in FrameData and set it when adding to sharedFrames.


Diffs
-----

  autotests/framesvgtest.h 4d31e10 
  autotests/framesvgtest.cpp e3c1f33 
  src/plasma/framesvg.cpp 96b3156 
  src/plasma/private/framesvg_p.h beee956 

Diff: https://git.reviewboard.kde.org/r/127344/diff/


Testing
-------

Test not crashing


Thanks,

David Rosca

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160312/f60a2e07/attachment.html>


More information about the Plasma-devel mailing list