Review Request 127344: FrameSvg: Fix dangling pointers in sharedFrames when theme changes

[Marco Martin]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127344/#review93423
-----------------------------------------------------------


Ship it!




Ship It!

- Marco Martin


On March 11, 2016, 6:45 p.m., David Rosca wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127344/
> -----------------------------------------------------------
> 
> (Updated March 11, 2016, 6:45 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> -------
> 
> Store theme pointer in FrameData and set it when adding to sharedFrames.
> 
> 
> Diffs
> -----
> 
>   autotests/framesvgtest.h 4d31e10 
>   autotests/framesvgtest.cpp e3c1f33 
>   src/plasma/framesvg.cpp 96b3156 
>   src/plasma/private/framesvg_p.h beee956 
> 
> Diff: https://git.reviewboard.kde.org/r/127344/diff/
> 
> 
> Testing
> -------
> 
> Test not crashing
> 
> 
> Thanks,
> 
> David Rosca
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160311/1e99ed8c/attachment.html>