[Differential] [Request, 38 lines] D1107: Opening activity configuration as a modal dialog when calling from kcm

[ivan (Ivan Čukić)]

ivan created this revision.
ivan added a reviewer: davidedmundson.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.

REVISION SUMMARY
  We turned of the modal-ness of the activity configuration dialogue
  so that we do not block plasma (https://git.reviewboard.kde.org/r/126945/)
  but this introduced a problem when the dialog is opened from the kcm.
  
  This patch allows creating the dialog both as modal and not.
  Plasma uses the non-modal version, KCM uses the modal one.
  
  Now, there is a question whether this is smart to do from KCM as well?

REPOSITORY
  rPLASMADESKTOP Plasma Desktop

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D1107

AFFECTED FILES
  desktoppackage/contents/activitymanager/ActivityItem.qml
  desktoppackage/contents/activitymanager/StoppedActivityItem.qml
  kcms/activities/imports/activitysettings.cpp
  kcms/activities/imports/activitysettings.h
  kcms/activities/imports/dialog.cpp
  kcms/activities/imports/dialog.h
  kcms/activities/qml/activitiesTab/ActivitiesView.qml

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: ivan, davidedmundson
Cc: plasma-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160310/18940138/attachment.html>