<div>ivan created this revision.<br />
ivan added a reviewer: davidedmundson.<br />
Herald added a project: Plasma.<br />
Herald added a subscriber: plasma-devel.</div><br /><div><strong>REVISION SUMMARY</strong><div><p>We turned of the modal-ness of the activity configuration dialogue<br />
so that we do not block plasma (<a href="https://git.reviewboard.kde.org/r/126945/" class="remarkup-link" target="_blank" rel="noreferrer">https://git.reviewboard.kde.org/r/126945/</a>)<br />
but this introduced a problem when the dialog is opened from the kcm.</p>

<p>This patch allows creating the dialog both as modal and not.<br />
Plasma uses the non-modal version, KCM uses the modal one.</p>

<p>Now, there is a question whether this is smart to do from KCM as well?</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>rPLASMADESKTOP Plasma Desktop</div></div></div><br /><div><strong>BRANCH</strong><div><div>master</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D1107" rel="noreferrer">https://phabricator.kde.org/D1107</a></div></div><br /><div><strong>AFFECTED FILES</strong><div><div>desktoppackage/contents/activitymanager/ActivityItem.qml<br />
desktoppackage/contents/activitymanager/StoppedActivityItem.qml<br />
kcms/activities/imports/activitysettings.cpp<br />
kcms/activities/imports/activitysettings.h<br />
kcms/activities/imports/dialog.cpp<br />
kcms/activities/imports/dialog.h<br />
kcms/activities/qml/activitiesTab/ActivitiesView.qml</div></div></div><br /><div><strong>EMAIL PREFERENCES</strong><div><a href="https://phabricator.kde.org/settings/panel/emailpreferences/" rel="noreferrer">https://phabricator.kde.org/settings/panel/emailpreferences/</a></div></div><br /><div><strong>To: </strong>ivan, davidedmundson<br /><strong>Cc: </strong>plasma-devel<br /></div>