Review Request 127313: [Icon Item] Don't call loadPixmap in setColorGroup

[Kai Uwe Broulik]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127313/
-----------------------------------------------------------

(Updated March 10, 2016, 11:58 a.m.)


Status
------

This change has been marked as submitted.


Review request for Plasma.


Changes
-------

Submitted with commit 3b115e6d901fc9e74c6393ce21415d13e286a9eb by Kai Uwe Broulik to branch master.


Repository: plasma-framework


Description
-------

Changing the color group of an Svg emits repaintNeeded which will then cause it to schedule a pixmap update anyway.


Diffs
-----

  autotests/iconitemtest.h c7ba89f 
  autotests/iconitemtest.cpp ae825a9 
  src/declarativeimports/core/iconitem.cpp 6c23a7e 

Diff: https://git.reviewboard.kde.org/r/127313/diff/


Testing
-------

It doesn't work but that's unrelated to the loadPixmap call(); the icon item is updated but SVG still renders an SVG with the normal color group, investigating...


Thanks,

Kai Uwe Broulik

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160310/59c7f7ff/attachment.html>