Review Request 127313: [Icon Item] Don't call loadPixmap in setColorGroup

[David Edmundson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127313/#review93364
-----------------------------------------------------------


Ship it!




Ship It!

- David Edmundson


On March 9, 2016, 11:33 a.m., Kai Uwe Broulik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127313/
> -----------------------------------------------------------
> 
> (Updated March 9, 2016, 11:33 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> -------
> 
> Changing the color group of an Svg emits repaintNeeded which will then cause it to schedule a pixmap update anyway.
> 
> 
> Diffs
> -----
> 
>   autotests/iconitemtest.h c7ba89f 
>   autotests/iconitemtest.cpp ae825a9 
>   src/declarativeimports/core/iconitem.cpp 6c23a7e 
> 
> Diff: https://git.reviewboard.kde.org/r/127313/diff/
> 
> 
> Testing
> -------
> 
> It doesn't work but that's unrelated to the loadPixmap call(); the icon item is updated but SVG still renders an SVG with the normal color group, investigating...
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160309/5e2381e6/attachment.html>