Review Request 127294: Remove unsupported GRUB theme options

Daniel Vrátil dvratil at kde.org
Sun Mar 6 13:27:51 UTC 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127294/
-----------------------------------------------------------

(Updated March 6, 2016, 1:27 p.m.)


Status
------

This change has been marked as submitted.


Review request for Plasma and Harald Sitter.


Changes
-------

Submitted with commit a978617a84fa749bfae29d8cb15d8e2df4f2859d by Daniel Vrátil to branch Plasma/5.6.


Repository: breeze-grub


Description
-------

`terminal-color` and `terminal-bg-color` theme options are not supported by GRUB2 - there's no mention of them in any documentation or code. Maybe with some forgiving configuration the unknown options are ignored and the theme loaded, but at least in default configuration GRUB will refuse to load the theme.


Diffs
-----

  breeze/theme.txt 7a3be85 

Diff: https://git.reviewboard.kde.org/r/127294/diff/


Testing
-------

No errors on GRUB start, theme loads.


Thanks,

Daniel Vrátil

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160306/b5d0dc38/attachment-0001.html>


More information about the Plasma-devel mailing list