Review Request 127294: Remove unsupported GRUB theme options

[Harald Sitter]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127294/#review93234
-----------------------------------------------------------


Ship it!




Ship It!

- Harald Sitter


On March 6, 2016, 11:48 a.m., Daniel Vrátil wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127294/
> -----------------------------------------------------------
> 
> (Updated March 6, 2016, 11:48 a.m.)
> 
> 
> Review request for Plasma and Harald Sitter.
> 
> 
> Repository: breeze-grub
> 
> 
> Description
> -------
> 
> `terminal-color` and `terminal-bg-color` theme options are not supported by GRUB2 - there's no mention of them in any documentation or code. Maybe with some forgiving configuration the unknown options are ignored and the theme loaded, but at least in default configuration GRUB will refuse to load the theme.
> 
> 
> Diffs
> -----
> 
>   breeze/theme.txt 7a3be85 
> 
> Diff: https://git.reviewboard.kde.org/r/127294/diff/
> 
> 
> Testing
> -------
> 
> No errors on GRUB start, theme loads.
> 
> 
> Thanks,
> 
> Daniel Vrátil
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160306/553a39f2/attachment.html>