Review Request 127285: use QDBusConnectionInterface::serviceOwnerChanged to watch mpris2 service
Xuetian Weng
wengxt at gmail.com
Sat Mar 5 05:38:23 UTC 2016
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127285/
-----------------------------------------------------------
Review request for Plasma and Aleix Pol Gonzalez.
Repository: plasma-workspace
Description
-------
Not sure if this is an intented upstream change (I reported it anyway https://bugreports.qt.io/browse/QTBUG-51683 ), but QDBusServiceWatcher can't watch all service anymore in Qt 5.6 RC with empty service name string.
Let's simple use the "deprecated" QDBusConnectionInterface::serviceOwnerChanged signal to do this work, which is also used by qdbusviewer.
Diffs
-----
dataengines/mpris2/mpris2engine.cpp 064ca60
Diff: https://git.reviewboard.kde.org/r/127285/diff/
Testing
-------
mpris2 dataengine now back to work with qt 5.6.
Thanks,
Xuetian Weng
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160305/eb541ee5/attachment.html>
More information about the Plasma-devel
mailing list