Review Request 127282: IconItem: Don't overwrite source when using QIcon::name()

[David Rosca]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127282/
-----------------------------------------------------------

(Updated March 4, 2016, 10:49 p.m.)


Status
------

This change has been marked as submitted.


Review request for Plasma.


Changes
-------

Submitted with commit 978b8b3b87671ac6b3a365b6b5b3dbe42b2a017b by David Rosca to branch master.


Repository: plasma-framework


Description
-------

source should always return the same value as it was assigned.
Also removed duplicated code (empty sourceString is now handled as if the source couldn't be converted to any type).


Diffs
-----

  autotests/iconitemtest.h 2de8512 
  autotests/iconitemtest.cpp 8d3f494 
  src/declarativeimports/core/iconitem.h 651a101 
  src/declarativeimports/core/iconitem.cpp b1c4c7a 

Diff: https://git.reviewboard.kde.org/r/127282/diff/


Testing
-------

Tests pass.


Thanks,

David Rosca

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160304/13a4c422/attachment.html>