Review Request 127248: More weather dataengine ion plugins cleanup/port (for 5.6)

[Friedrich W. H. Kossebau]

> On March 1, 2016, 8:26 p.m., David Edmundson wrote:
> > dataengines/weather/ions/envcan/CMakeLists.txt, line 9
> > <https://git.reviewboard.kde.org/r/127248/diff/1/?file=447726#file447726line9>
> >
> >     translation domain needs settings 
> >     
> >     (bbc too) and possibly wetter.com if it's not done already.

There is

    add_definitions(-DTRANSLATION_DOMAIN=\"plasma_engine_weather\")

in the CMakeLists.txt two levels above and before the `ions` subdir is included, that should cover this already. At least to what I know, so please reopen if I am wrong :)
That is also the place where the Messages.sh sits which cares for all these sources.


- Friedrich W. H.


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127248/#review93038
-----------------------------------------------------------


On March 1, 2016, 8:10 p.m., Friedrich W. H. Kossebau wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127248/
> -----------------------------------------------------------
> 
> (Updated March 1, 2016, 8:10 p.m.)
> 
> 
> Review request for Plasma and Marco Martin.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> -------
> 
> Port was simple, by following the one you did for the wettercom ion :)
> 
> Sadly found that the bbc one no longer works, at least the location search url used is redirected to the normal start webpage. So I still propose to apply the changes so it builds, but disable from build.
> 
> And the debianweather engine no longer has a service to use, as reported by its author on #plasma:
> ```
> [20:28] <svuorela> frinring_: it was a weather service translating the state of the debian archive into weather.
> [20:28] <svuorela> if the weather was cloudy or heavy rain, consider not upgrading
> [20:28] <frinring_> indicates a project of fun :)
> [20:29] <-- Nightrose (~lydia at kde/lydia) hat diesen Server verlassen (Ping timeout: 276 seconds).
> [20:29] <frinring_> svuorela: "was" means it is dead? and we could just remove the plugin for it?
> [20:29] <svuorela> I think it might be dead yes . let me investigate
> [20:34] <svuorela> frinring_: yeah. it seems dead. 
> [20:34] <svuorela> feel free to fix with git rm
> ```
> 
> 
> Diffs
> -----
> 
>   dataengines/weather/ions/CMakeLists.txt e59e0db 
>   dataengines/weather/ions/bbcukmet/CMakeLists.txt a8f1ec1 
>   dataengines/weather/ions/bbcukmet/ion_bbcukmet.h 9dbdbf7 
>   dataengines/weather/ions/bbcukmet/ion_bbcukmet.cpp d2d47fa 
>   dataengines/weather/ions/debianweather/CMakeLists.txt 05c217d 
>   dataengines/weather/ions/debianweather/ion-debianweather.desktop 650e4e7 
>   dataengines/weather/ions/debianweather/iondebianweather.h a3ca110 
>   dataengines/weather/ions/debianweather/iondebianweather.cpp 6525144 
>   dataengines/weather/ions/envcan/CMakeLists.txt a3daa55 
>   dataengines/weather/ions/envcan/ion_envcan.h 19407d6 
>   dataengines/weather/ions/envcan/ion_envcan.cpp 56efc7a 
> 
> Diff: https://git.reviewboard.kde.org/r/127248/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Friedrich W. H. Kossebau
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160301/87b9bf69/attachment-0001.html>