<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/127248/">https://git.reviewboard.kde.org/r/127248/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On March 1st, 2016, 8:26 p.m. UTC, <b>David Edmundson</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/127248/diff/1/?file=447726#file447726line9" style="color: black; font-weight: bold; text-decoration: underline;">dataengines/weather/ions/envcan/CMakeLists.txt</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">9</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">translation domain needs settings </p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">(bbc too) and possibly wetter.com if it's not done already.</p></pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">There is</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;"><div class="codehilite" style="background: #f8f8f8"><pre style="line-height: 125%">add_definitions(-DTRANSLATION_DOMAIN=\"plasma_engine_weather\")
</pre></div>
</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">in the CMakeLists.txt two levels above and before the <code style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: 0;line-height: inherit;">ions</code> subdir is included, that should cover this already. At least to what I know, so please reopen if I am wrong :)
That is also the place where the Messages.sh sits which cares for all these sources.</p></pre>
<br />
<p>- Friedrich W. H.</p>
<br />
<p>On March 1st, 2016, 8:10 p.m. UTC, Friedrich W. H. Kossebau wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Plasma and Marco Martin.</div>
<div>By Friedrich W. H. Kossebau.</div>
<p style="color: grey;"><i>Updated March 1, 2016, 8:10 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-workspace
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Port was simple, by following the one you did for the wettercom ion :)</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Sadly found that the bbc one no longer works, at least the location search url used is redirected to the normal start webpage. So I still propose to apply the changes so it builds, but disable from build.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">And the debianweather engine no longer has a service to use, as reported by its author on #plasma:</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;"><div class="codehilite" style="background: #f8f8f8"><pre style="line-height: 125%">[20:28] <svuorela> frinring_: it was a weather service translating the state of the debian archive into weather.
[20:28] <svuorela> if the weather was cloudy or heavy rain, consider not upgrading
[20:28] <frinring_> indicates a project of fun :)
[20:29] <-- Nightrose (~lydia@kde/lydia) hat diesen Server verlassen (Ping timeout: 276 seconds).
[20:29] <frinring_> svuorela: "was" means it is dead? and we could just remove the plugin for it?
[20:29] <svuorela> I think it might be dead yes . let me investigate
[20:34] <svuorela> frinring_: yeah. it seems dead.
[20:34] <svuorela> feel free to fix with git rm
</pre></div>
</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>dataengines/weather/ions/CMakeLists.txt <span style="color: grey">(e59e0db)</span></li>
<li>dataengines/weather/ions/bbcukmet/CMakeLists.txt <span style="color: grey">(a8f1ec1)</span></li>
<li>dataengines/weather/ions/bbcukmet/ion_bbcukmet.h <span style="color: grey">(9dbdbf7)</span></li>
<li>dataengines/weather/ions/bbcukmet/ion_bbcukmet.cpp <span style="color: grey">(d2d47fa)</span></li>
<li>dataengines/weather/ions/debianweather/CMakeLists.txt <span style="color: grey">(05c217d)</span></li>
<li>dataengines/weather/ions/debianweather/ion-debianweather.desktop <span style="color: grey">(650e4e7)</span></li>
<li>dataengines/weather/ions/debianweather/iondebianweather.h <span style="color: grey">(a3ca110)</span></li>
<li>dataengines/weather/ions/debianweather/iondebianweather.cpp <span style="color: grey">(6525144)</span></li>
<li>dataengines/weather/ions/envcan/CMakeLists.txt <span style="color: grey">(a3daa55)</span></li>
<li>dataengines/weather/ions/envcan/ion_envcan.h <span style="color: grey">(19407d6)</span></li>
<li>dataengines/weather/ions/envcan/ion_envcan.cpp <span style="color: grey">(56efc7a)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/127248/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>