Review Request 127229: Workaround bug 352055

[Marco Martin]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127229/#review92970
-----------------------------------------------------------


Ship it!




Yeah, either this or changing systray for 5.6 already :/
and i think it's an issue in Qml, since it's very old code and this problem really started only on 5.6 branch of Qt

- Marco Martin


On Feb. 29, 2016, 10:16 p.m., Xuetian Weng wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127229/
> -----------------------------------------------------------
> 
> (Updated Feb. 29, 2016, 10:16 p.m.)
> 
> 
> Review request for Plasma and Marco Martin.
> 
> 
> Bugs: 352055
>     https://bugs.kde.org/show_bug.cgi?id=352055
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> -------
> 
> From my debug, the real problem is that the model value in qml some times can have wrong value. When there is the "empty" space in systray, model.index obtained from delegate is -1 and no any other data is available, which should never happens.
> 
> This is obviously a bug in Qt.. but unfortunately I have no simple test case to reproduce it.
> 
> 
> Diffs
> -----
> 
>   applets/systemtray/plugin/tasklistmodel.cpp 1fa306c 
> 
> Diff: https://git.reviewboard.kde.org/r/127229/diff/
> 
> 
> Testing
> -------
> 
> Works for me at least.
> 
> 
> Thanks,
> 
> Xuetian Weng
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160301/1a3dc202/attachment.html>