Review Request 127229: Workaround bug 352055

[David Edmundson]

> On Feb. 29, 2016, 11:38 p.m., Aleix Pol Gonzalez wrote:
> > -1.
> > 
> > You are suggesting us that we don't know what's going on, so we add things that have a bigger impact and see if things stick.
> > 
> > Suggestion:
> > - Run the model with modeltest: https://wiki.qt.io/Model_Test
> > - Create unit tests.

Model test passes perfect. That's been done to death.

We don't know what's going on .


- David


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127229/#review92955
-----------------------------------------------------------


On Feb. 29, 2016, 10:16 p.m., Xuetian Weng wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127229/
> -----------------------------------------------------------
> 
> (Updated Feb. 29, 2016, 10:16 p.m.)
> 
> 
> Review request for Plasma and Marco Martin.
> 
> 
> Bugs: 352055
>     https://bugs.kde.org/show_bug.cgi?id=352055
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> -------
> 
> From my debug, the real problem is that the model value in qml some times can have wrong value. When there is the "empty" space in systray, model.index obtained from delegate is -1 and no any other data is available, which should never happens.
> 
> This is obviously a bug in Qt.. but unfortunately I have no simple test case to reproduce it.
> 
> 
> Diffs
> -----
> 
>   applets/systemtray/plugin/tasklistmodel.cpp 1fa306c 
> 
> Diff: https://git.reviewboard.kde.org/r/127229/diff/
> 
> 
> Testing
> -------
> 
> Works for me at least.
> 
> 
> Thanks,
> 
> Xuetian Weng
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160301/a86b7712/attachment.html>