[Differential] [Commented On] D1956: Create logging categories via CMake

davidedmundson (David Edmundson) noreply at phabricator.kde.org
Mon Jun 20 13:45:53 UTC 2016


davidedmundson added inline comments.

INLINE COMMENTS

> graesslin wrote in CMakeLists.txt:10
> Why SYSTEM_TRAY and not SYSTEMTRAY? It looks like lots was touched just to add the underscore.

Good question, with a very frustrating answer.
otherwise macro creates a file with the guard SYSTEMTRAY_H which is the guard of this file.

see https://git.reviewboard.kde.org/r/128231/

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D1956

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: davidedmundson, #plasma
Cc: graesslin, plasma-devel, jensreuterberg, sebas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160620/a5a6fec0/attachment-0001.html>


More information about the Plasma-devel mailing list