[Differential] [Changed Subscribers] D1956: Create logging categories via CMake

graesslin (Martin Gräßlin) noreply at phabricator.kde.org
Mon Jun 20 06:11:04 UTC 2016


graesslin added inline comments.

INLINE COMMENTS

> CMakeLists.txt:10
> +ecm_qt_declare_logging_category(systemtray_SRCS HEADER debug.h
> +                                            IDENTIFIER SYSTEM_TRAY
> +                                            CATEGORY_NAME kde.systemtray

Why SYSTEM_TRAY and not SYSTEMTRAY? It looks like lots was touched just to add the underscore.

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D1956

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: davidedmundson, #plasma
Cc: graesslin, plasma-devel, jensreuterberg, sebas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160620/9a0bd80a/attachment-0001.html>


More information about the Plasma-devel mailing list