[Differential] [Accepted] D1952: Don't set width and height in a layout

[broulik (Kai Uwe Broulik)]

broulik accepted this revision.
broulik added a reviewer: broulik.
broulik added a comment.
This revision is now accepted and ready to land.


  I just noticed I had an uncommited change which tried to solve the same thing:
  
    -                width: units.iconSizes.smallMedium
    -                height: width
    +                Layout.preferredWidth: units.iconSizes.smallMedium
    +                Layout.fillHeight: true
  
  But yours is clearly better.

REPOSITORY
  rPLASMADESKTOP Plasma Desktop

BRANCH
  pager

REVISION DETAIL
  https://phabricator.kde.org/D1952

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: davidedmundson, #plasma, broulik
Cc: broulik, plasma-devel, jensreuterberg, sebas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160618/4757ec44/attachment.html>