<table><tr><td style="">broulik accepted this revision.<br />broulik added a reviewer: broulik.<br />broulik added a comment.<br />This revision is now accepted and ready to land.</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D1952" rel="noreferrer">View Revision</a></tr></table><br /><div><div><p>I just noticed I had an uncommited change which tried to solve the same thing:</p>
<div class="remarkup-code-block" style="margin: 12px 0;" data-code-lang="text" data-sigil="remarkup-code-block"><pre class="remarkup-code" style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; padding: 12px; margin: 0; background: rgba(71, 87, 120, 0.08);">- width: units.iconSizes.smallMedium
- height: width
+ Layout.preferredWidth: units.iconSizes.smallMedium
+ Layout.fillHeight: true</pre></div>
<p>But yours is clearly better.</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>rPLASMADESKTOP Plasma Desktop</div></div></div><br /><div><strong>BRANCH</strong><div><div>pager</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D1952" rel="noreferrer">https://phabricator.kde.org/D1952</a></div></div><br /><div><strong>EMAIL PREFERENCES</strong><div><a href="https://phabricator.kde.org/settings/panel/emailpreferences/" rel="noreferrer">https://phabricator.kde.org/settings/panel/emailpreferences/</a></div></div><br /><div><strong>To: </strong>davidedmundson, Plasma, broulik<br /><strong>Cc: </strong>broulik, plasma-devel, jensreuterberg, sebas<br /></div>