[Differential] [Request, 156 lines] D1934: Cleanup use of TasksModel data roles.
hein (Eike Hein)
noreply at phabricator.kde.org
Fri Jun 17 09:50:39 UTC 2016
hein created this revision.
hein added reviewers: broulik, dfaure.
hein added a subscriber: plasma-devel.
Restricted Application added a project: Plasma.
REVISION SUMMARY
Avoid a wall of prop rebindings to access roles outside the delegates
causing unnecessary calls to data().
Be 'typesafe' about testing against true. If a role returns QVariant(),
just binding it to e.g. a 'visible' prop still evaluates to true
incorrectly otherwise.
REPOSITORY
rPLASMADESKTOP Plasma Desktop
BRANCH
Plasma/5.7
REVISION DETAIL
https://phabricator.kde.org/D1934
AFFECTED FILES
applets/taskmanager/package/contents/code/layout.js
applets/taskmanager/package/contents/code/tools.js
applets/taskmanager/package/contents/ui/ContextMenu.qml
applets/taskmanager/package/contents/ui/GroupExpanderOverlay.qml
applets/taskmanager/package/contents/ui/MouseHandler.qml
applets/taskmanager/package/contents/ui/Task.qml
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: hein, broulik, dfaure
Cc: plasma-devel, jensreuterberg, sebas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160617/a8305a51/attachment.html>
More information about the Plasma-devel
mailing list