<table><tr><td style="">hein created this revision.<br />hein added reviewers: broulik, dfaure.<br />hein added a subscriber: plasma-devel.<br />Restricted Application added a project: Plasma.</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D1934" rel="noreferrer">View Revision</a></tr></table><br /><div><strong>REVISION SUMMARY</strong><div><p>Avoid a wall of prop rebindings to access roles outside the delegates<br />
causing unnecessary calls to data().</p>

<p>Be 'typesafe' about testing against true. If a role returns QVariant(),<br />
just binding it to e.g. a 'visible' prop still evaluates to true<br />
incorrectly otherwise.</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>rPLASMADESKTOP Plasma Desktop</div></div></div><br /><div><strong>BRANCH</strong><div><div>Plasma/5.7</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D1934" rel="noreferrer">https://phabricator.kde.org/D1934</a></div></div><br /><div><strong>AFFECTED FILES</strong><div><div>applets/taskmanager/package/contents/code/layout.js<br />
applets/taskmanager/package/contents/code/tools.js<br />
applets/taskmanager/package/contents/ui/ContextMenu.qml<br />
applets/taskmanager/package/contents/ui/GroupExpanderOverlay.qml<br />
applets/taskmanager/package/contents/ui/MouseHandler.qml<br />
applets/taskmanager/package/contents/ui/Task.qml</div></div></div><br /><div><strong>EMAIL PREFERENCES</strong><div><a href="https://phabricator.kde.org/settings/panel/emailpreferences/" rel="noreferrer">https://phabricator.kde.org/settings/panel/emailpreferences/</a></div></div><br /><div><strong>To: </strong>hein, broulik, dfaure<br /><strong>Cc: </strong>plasma-devel, jensreuterberg, sebas<br /></div>